Auto-Approve on ProxyWhereabouts.com

Quote:

---

Originally Posted by Ogle

Actually, do not blame the browser. IE is doing it correctly, firefox is not.

In your HTML:

PHP Code:

---

<select name="category" style="width: 350px; height: 20px; background-color:#DDDDCB" >
        <option value="PHP
">PHP
</option>        <option value="Glype
">Glype
</option> 


---

So value = "PHP
" (It includes the newline)
And that is what %0D%0A is, some sort of encoded new line feed.

You can fix this by either formating your HTML correctly, but you should really just use better input validation :thumbsup:

---

I was already aware of that, of course I had to debug the file to figure it out that I.E was adding garbage output becuase of the new line. I'm not the who coded that part. It is put onto the page with a foreach & echo. But for some reason its adding another line. Firefox is still the better one, that kind of tabbed line %0D%0A wouldn't be valid even if you wanted it too. Firefox is smart to remove it.
I.E is just being technical and thats why I gets on my nerves. :)

I've looked on it but have got no clue how to fix this. Like Keldorn said, it was there from for each and echo. But, instead of calling from a text file, can I just put the category in array?

Quote:

---

Originally Posted by proxywhereabouts

I've looked on it but have got no clue how to fix this. Like Keldorn said, it was there from for each and echo. But, instead of calling from a text file, can I just put the category in array?

---

You actually don't need to fix it as there is a trim($_POST['category']) there that removes the tabbed line dripple, so there is no error in Internet explorer. But if you wanted to figure it out. It deffinatly would be this code. Something is wrong with it.

PHP Code:

---

<?php
$cat_list = @file("categories.txt");
$count_cat=count($cat_list);

for ($i=0;$i<$count_cat;$i++){
echo <<<D
        <option value="$cat_list[$i]">$cat_list[$i]</option>
D;
}
?>

---

For some reason after $cat_list[$i] it adds a new line, which isnt there in the code as you can see, so its an unexpected output. ;)

Quote:

---

Originally Posted by Keldorn

You actually don't need to fix it as there is a trim($_POST['category']) there that removes the tabbed line dripple, so there is no error in Internet explorer. But if you wanted to figure it out. It deffinatly would be this code. Something is wrong with it.

PHP Code:

---

<?php
$cat_list = @file("categories.txt");
$count_cat=count($cat_list);

for ($i=0;$i<$count_cat;$i++){
echo <<<D
        <option value="$cat_list[$i]">$cat_list[$i]</option>
D;
}
?>

---

For some reason after $cat_list[$i] it adds a new line, which isnt there in the code as you can see, so its an unexpected output. ;)

---

lol..this thread has become a help/support thread for the script.:o
Btw, what does this complement?

PHP Code:

---

echo <<<D 


---

support thread. :rolleyes: Do you know how many security holes and bugs is in that script? That person who charged $199 for it should be ashamed of themselves.

On a lighter note I think I know why it would be adding a new line. Since $cat_list is an associative array of categories.txt which has each category listed on a new line in the .txt file, the array itself has new line returns on each category.
Which I belive in the file system is seen as a "\n"
You will want to walk each value in the array threw trim();

PHP Code:

---

    // Remove white Space from Array values
    function trim_value(&$value) { 
    
           $value = trim($value); 
           
    }

$cat_list = @file("categories.txt");

array_walk($cat_list, 'trim_value');

$count_cat=count($cat_list);

for ($i=0;$i<$count_cat;$i++){
echo <<<D
        <option value="$cat_list[$i]">$cat_list[$i]</option>
D;
}
?> 


---

I believe the reason script author put it as $199 was because he seems to be the first to release such script for proxy..well, I might be wrong though.

Thanks for the code. I skipped that trim declare as it already been declare on top of the script. Looks better now?

Quote:

---

Originally Posted by proxywhereabouts

I believe the reason script author put it as $199 was because he seems to be the first to release such script for proxy..well, I might be wrong though.

Thanks for the code. I skipped that trim declare as it already been declare on top of the script. Looks better now?

---

I see

Code:

---

<option value="PHP">PHP</option><option value="Glype">Glype</option><option value="Zelune">Zelune</option><option value="CGI">CGI</option><option value="Happy">Happy</option><option value="Proxono">Proxono</option><option value="Surrografier">Surrografier</option><option value="phpMyProxy">phpMyProxy</option>        <option value="PHPhantom">PHPhantom</option><option value="Custom Proxies">Custom Proxies</option></select><br><br>

---

In your html now
Hey it might be all on one line, but its still valid html markup.
Keldorn

:P You edit your reply just now.. ;)

Yes it works. Thanks so much for the fix. Appreciate it so much.

While that worked its still a little rigged.

There is no reason at all for it to be done like this in the first place

Code:

---

for ($i=0;$i<$count_cat;$i++){
echo <<<D
        <option value="$cat_list[$i]">$cat_list[$i]</option>
D;


---

instead

Code:

---

for ($i=0;$i<$count_cat;$i++)
{

echo "<option value=\"$cat_list[$i]\">$cat_list[$i]</option>";

}

---

If that errors out change to echo ' ';

Quote:

---

Originally Posted by proxywhereabouts

lol..this thread has become a help/support thread for the script.:o
Btw, what does this complement?

PHP Code:

---

echo <<<D 


---

---

It is a useful way to push out large sets of text while keeping the formatting (hence the encoded newline IE was sending correctly(!)- it has a strange name which I can not remember. In my view there is no reason at all to use it here.

Laughable that someone charges $200 for this

Quote:

---

Originally Posted by Ogle

Code:

---

for ($i=0;$i<$count_cat;$i++)
{

echo "<option value=\"$cat_list[$i]\">$cat_list[$i]</option>";

}

---

---

I would also suggest a new line break.

echo "<option value=\"$cat_list[$i]\">$cat_list[$i]</option>" . "\n";

(Which Ironically enough the cause of the trouble before.